Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocTypeGridEditor previews broken after upgrade due to IContentService.GetById(int id) returning null #15464

Closed
tcollettCDSM opened this issue Dec 15, 2023 · 4 comments
Labels

Comments

@tcollettCDSM
Copy link

tcollettCDSM commented Dec 15, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.8.2

Bug summary

Previews in DocTypeGridEditor (v10.0.1) no longer work after upgrading from umbraco 10.7.0 to v10.8.2

Specifics

DocTypeGridEditor tries to get the content to display in the preview by calling GetById in its constructor and then tries to get the content type from this

After doing some debugging locally, I found that the GetById was returning null despite the fact a POST to /umbraco/backoffice/umbracoapi/content/PostSaveBlueprint has happened by this point (demonstrated by video in repro steps)
image

This was working in 10.7.0, so the issue probably was introduced after that point (changelog for 10.8.0 mentions performance optimisations for blocks which might be relevant?)

Steps to reproduce

  1. Author a NestedContent item with an element type inside (I use a rich text editor in this example)
  2. Open devtools & click submit in the editor
  3. See the preview not update and the 500 error in devtools
Gridpreviewissue.mp4

Expected result / actual result

IContentService.GetById(int id) should not return null when it didn't before

Copy link

Hi there @tcollettCDSM!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Dec 15, 2023

I will close this as a duplicate of #15460
Seems the /umbraco/backoffice/umbracoapi/content/PostSaveBlueprint has been broken

Thanks for the additional information!

@Zeegaan Zeegaan closed this as completed Dec 15, 2023
@tcollettCDSM
Copy link
Author

Updated to 10.8.3 but the issue I flagged still remains unfortunately, any chance this'll be looked at at again?

@Zeegaan
Copy link
Member

Zeegaan commented Jan 11, 2024

There has been a discussion on #15460 about DocTypeGridEditor, so I will refer you to that issue 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants