-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umbraco 13, Block Grid > RTE > Embedded Block Editors Don't Always Render #15494
Comments
Hi there @asawyermarathon! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks for reaching out @asawyermarathon 👋 and for the detailed description of how to reproduce the issue I was able to reproduce the issue, so we will take a look. Have a joyful new year! 🎊 |
Using version 13.0.3
I did have a Block render once if it was the last element by editing out some text elsewhere in the rich text. But then it disappeared again after another save. Possibly because the empty p-tag was removed. |
I noticed that when the block is added, it's added with a class attribute (probably from AngularJS) This makes it not match the Regex found in https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/RichTextParsingRegexes.cs So I guess, either the regex should be updated to allow for the class attribute, or the class attribute should be removed somehow. The regex could be changed to |
fixed in #15583 |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
13.0.2
Bug summary
Specifics
No response
Steps to reproduce
https://github.com/umbraco/Umbraco-CMS/assets/87725234/76eebdd7-d363-4746-8a31-e450aa6e1f76
https://github.com/umbraco/Umbraco-CMS/assets/87725234/a2d2e4d4-f2a7-48cf-a143-29f70fd1e5b3
Content:
Output:
Expected result / actual result
I expected RTE with an embedded Block Editor to be parsed and the block rendered when in a Block Grid field.
This item has been added to our backlog AB#36554
The text was updated successfully, but these errors were encountered: