Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UmbracoApplicationStartedNotification is not published asynchronously during start #15509

Closed
iliyan-kulishev opened this issue Dec 26, 2023 · 3 comments
Labels

Comments

@iliyan-kulishev
Copy link

iliyan-kulishev commented Dec 26, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.0.1

Bug summary

The notification is published async only during restart.

Specifics

Published async during restart:
image

Published sync during start:
image

Steps to reproduce

  • Have an handler that implements INotificationAsyncHandler<UmbracoApplicationStartedNotification>
  • Set a breakpoint in the body of the HandleAsync method

Expected result / actual result

Execution never hits the breakpoint.

Copy link

Hi there @iliyan-kulishev!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Jan 8, 2024

I cannot reproduce this sorry, It hits the HandleAsync breakpoint just fine, I've tried this on both 12.0.1 and latest 🙈
Here is my composer:
image

@Zeegaan Zeegaan added the state/needs-reproduction Check if this can be reproduced in the latest released version label Jan 8, 2024
@kjac
Copy link
Contributor

kjac commented Jan 23, 2025

I am also having a hard time reproducing this on V13.5.2.

Given this code:

using Umbraco.Cms.Core.Composing;
using Umbraco.Cms.Core.Events;
using Umbraco.Cms.Core.Notifications;

namespace My.Site;

public class MyNotificationHandler :
    INotificationAsyncHandler<UmbracoApplicationStartingNotification>,
    INotificationAsyncHandler<UmbracoApplicationStartedNotification>
{
    public Task HandleAsync(UmbracoApplicationStartingNotification notification, CancellationToken cancellationToken)
    {
        Console.WriteLine("#### APPLICATION STARTING ####");
        return Task.CompletedTask;
    }

    public Task HandleAsync(UmbracoApplicationStartedNotification notification, CancellationToken cancellationToken)
    {
        Console.WriteLine("#### APPLICATION STARTED ####");
        return Task.CompletedTask;
    }
}

public class MyNotificationHandlerComposer : IComposer
{
    public void Compose(IUmbracoBuilder builder)
        => builder
            .AddNotificationAsyncHandler<UmbracoApplicationStartingNotification, MyNotificationHandler>()
            .AddNotificationAsyncHandler<UmbracoApplicationStartedNotification, MyNotificationHandler>();
}

The expected console logging happens:

Image

I'll go ahead and close this one 👍

@kjac kjac closed this as completed Jan 23, 2025
@kjac kjac removed the state/needs-reproduction Check if this can be reproduced in the latest released version label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants