Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste from clipboard on Block Grid not filtering allowed types #18177

Open
jveer opened this issue Jan 30, 2025 · 6 comments
Open

Paste from clipboard on Block Grid not filtering allowed types #18177

jveer opened this issue Jan 30, 2025 · 6 comments

Comments

@jveer
Copy link

jveer commented Jan 30, 2025

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.2.0-RC

Bug summary

When pasting a clipboard item on the Block Grid, it doesn't check for the allowed types (for example restricted by Allow i nroot, Allow in areas, or types set in the areas).

Specifics

No response

Steps to reproduce

These steps assume the content blocks have already been stored in the clipboard.

  1. Create a Block Grid with at least two element types.Image

  2. Set one of them to not be allowed in root.
    Image

  3. Go to the content page to add an element, note that it is correctly filtered on the types that are allowed on the root:
    Image

  4. When pasting from clipboard on the root, it allows all types that are added on the Block Grid, regardless of the check:
    Image

This also applies when element types are limited through the areas.

Expected result / actual result

Only allow adding element types from the clipboard, that are allowed at the location.

@jveer jveer added the type/bug label Jan 30, 2025
Copy link

Hi there @jveer!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @jveer , could you describe more clearly in step 4, how did you add "Home - Layout - Title Text Block" into the Clipboard?
I assume that "Home - Layout - Title Text Block" is disabled Allow in root

@jveer
Copy link
Author

jveer commented Feb 4, 2025

Hi @jveer , could you describe more clearly in step 4, how did you add "Home - Layout - Title Text Block" into the Clipboard? I assume that "Home - Layout - Title Text Block" is disabled Allow in root

I copied it from a different Block Grid data type / property, but in theory if you allow it to be used in areas you could copy it from that area as well.

Another way to reproduce is:

  1. Enabling Allow in root
  2. Copy the item
  3. Disable Allow in root
  4. Continue

@NguyenThuyLan
Copy link
Contributor

Thanks @jveer ,I was able to reproduce it on 15.2.0-RC. It should be fixed

@nul800sebastiaan
Copy link
Member

Thanks @jveer ,I was able to reproduce it on 15.2.0-RC. It should be fixed

To clarify:

  1. you were able to reproduce the problem on 15.2.0-rc
  2. we need to fix it, it is not already fixed

Is that correct?

@NguyenThuyLan
Copy link
Contributor

Yes @nul800sebastiaan 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants