-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste from clipboard on Block Grid not filtering allowed types #18177
Comments
Hi there @jveer! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @jveer , could you describe more clearly in step 4, how did you add "Home - Layout - Title Text Block" into the Clipboard? |
I copied it from a different Block Grid data type / property, but in theory if you allow it to be used in areas you could copy it from that area as well. Another way to reproduce is:
|
Thanks @jveer ,I was able to reproduce it on 15.2.0-RC. It should be fixed |
To clarify:
Is that correct? |
Yes @nul800sebastiaan 😊 |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
15.2.0-RC
Bug summary
When pasting a clipboard item on the Block Grid, it doesn't check for the allowed types (for example restricted by
Allow i nroot
,Allow in areas
, or types set in theareas
).Specifics
No response
Steps to reproduce
These steps assume the content blocks have already been stored in the clipboard.
Create a![Image](https://private-user-images.githubusercontent.com/23453777/408182197-245ce8ff-35f3-4dd0-b989-8b83b1efa998.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTEyNDIsIm5iZiI6MTczOTM5MDk0MiwicGF0aCI6Ii8yMzQ1Mzc3Ny80MDgxODIxOTctMjQ1Y2U4ZmYtMzVmMy00ZGQwLWI5ODktOGI4M2IxZWZhOTk4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMDkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU1YmU0ZjZlNTcyODIzNGFmMmJkMjM2NWM5NmRkZWE2ZjZhNjFlMTc5YjkzNzhjZjUwYzc4OTEzOThiOGEwYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.m6s9Pc3ouUKs0LK1mDacoD9N3-3nApeFKqQT618WCQM)
Block Grid
with at least two element types.Set one of them to not be allowed in root.
![Image](https://private-user-images.githubusercontent.com/23453777/408182346-c2bb2c32-d46a-4af8-92d4-d3e330a7602f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTEyNDIsIm5iZiI6MTczOTM5MDk0MiwicGF0aCI6Ii8yMzQ1Mzc3Ny80MDgxODIzNDYtYzJiYjJjMzItZDQ2YS00YWY4LTkyZDQtZDNlMzMwYTc2MDJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMDkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkYzQ4MDVjNmZlMTc1YzkyNWFjYzY0YjE1ODlhM2UzNzc4NmI4YzFlMDY3MGYyOGExMTU1NDc0MDNiNTg1MjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jp-Ivc9eTAnghapiH2ragoqMnFv0ZDDZ5l0lwzNdLg0)
Go to the content page to add an element, note that it is correctly filtered on the types that are allowed on the root:
![Image](https://private-user-images.githubusercontent.com/23453777/408183632-f61399f0-d3e4-4d60-bad7-6e5511e2caf7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTEyNDIsIm5iZiI6MTczOTM5MDk0MiwicGF0aCI6Ii8yMzQ1Mzc3Ny80MDgxODM2MzItZjYxMzk5ZjAtZDNlNC00ZDYwLWJhZDctNmU1NTExZTJjYWY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMDkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZjAwZGI4ZDNiMTIxNGJjMjA2NDhhODAxOTg5ZmM0NmZiMzVjMTVkYzg3ZDQyYmMwZmEwMDliZmVhY2Y4YzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KfDBgMbu6Ot_LdBRFPLUZTXcaxCXte1BmkjDUmfxRns)
When pasting from clipboard on the root, it allows all types that are added on the
![Image](https://private-user-images.githubusercontent.com/23453777/408183331-0bd8117a-c6ea-4d37-aa32-cafdc56d2cd7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTEyNDIsIm5iZiI6MTczOTM5MDk0MiwicGF0aCI6Ii8yMzQ1Mzc3Ny80MDgxODMzMzEtMGJkODExN2EtYzZlYS00ZDM3LWFhMzItY2FmZGM1NmQyY2Q3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMDkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkMTg0NTkyNWE5Y2M0MzAyNTBjMzlmMjViZGNhYTEzODBhZTk1MGUyNTE4YzNlYmZiNjEyZDExZGQ3MDk2YjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.u6DW4d_ximf376LO12cqsq4RafcLqo4XspAbWqurYlE)
Block Grid
, regardless of the check:This also applies when element types are limited through the
areas
.Expected result / actual result
Only allow adding element types from the clipboard, that are allowed at the location.
The text was updated successfully, but these errors were encountered: