You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
15.2
Bug summary
I am currently developing a custom WorkspaceAction by extending UmbWorkspaceActionBase. In this process, I need to determine whether there are any unpersisted changes before executing the action, similar to the check performed when navigating away from the workspace.
While reviewing the base class, I noticed the method _getHasUnpersistedChanges(): boolean:
Since this method is marked as protected, it cannot be accessed directly from a subclass. This restriction makes it difficult to implement a feature that needs to verify the presence of unsaved changes.
Request:
Would it be possible to either:
Remove the protected modifier from _getHasUnpersistedChanges() to make it accessible to subclasses, or
Provide an alternative public method to check for unpersisted changes?
This change would help developers building custom workspace actions and align with existing internal behaviors for unsaved change detection.
Specifics
No response
Steps to reproduce
Extend UmbWorkspaceActionBase and see that it is not accessible.
Expected result / actual result
No response
The text was updated successfully, but these errors were encountered:
Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.
We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.
And/or could you make a kind of observer/listener, that disables the WorkSpaceAction (button) if there are changes and enables the action if there are no changes?
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
15.2
Bug summary
I am currently developing a custom WorkspaceAction by extending UmbWorkspaceActionBase. In this process, I need to determine whether there are any unpersisted changes before executing the action, similar to the check performed when navigating away from the workspace.
While reviewing the base class, I noticed the method _getHasUnpersistedChanges(): boolean:
Umbraco-CMS/src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts
Line 386 in 3157601
Since this method is marked as protected, it cannot be accessed directly from a subclass. This restriction makes it difficult to implement a feature that needs to verify the presence of unsaved changes.
Request:
Would it be possible to either:
Remove the protected modifier from _getHasUnpersistedChanges() to make it accessible to subclasses, or
Provide an alternative public method to check for unpersisted changes?
This change would help developers building custom workspace actions and align with existing internal behaviors for unsaved change detection.
Specifics
No response
Steps to reproduce
Extend UmbWorkspaceActionBase and see that it is not accessible.
Expected result / actual result
No response
The text was updated successfully, but these errors were encountered: