Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gradle configuration cache #39

Open
jprinet opened this issue Nov 26, 2021 · 2 comments
Open

Support for Gradle configuration cache #39

jprinet opened this issue Nov 26, 2021 · 2 comments

Comments

@jprinet
Copy link

jprinet commented Nov 26, 2021

The Gradle configuration cache can't be enabled when using org.unbroken-dome.xjc Gradle plugin.

Quoting from the doc:

Gradle model types (e.g. Gradle, Settings, Project, SourceSet, Configuration etc…​) are usually used to carry some task input that should be explicitly and precisely declared instead.

Using a reference to the Configuration object is not supported:

abstract val catalogResolutionClasspath: Property<Configuration>

@eskatos
Copy link

eskatos commented Nov 26, 2021

catalogResolutionClasspath could be a ConfigurableFileCollection instead, which is supported by the configuration cache.

@dlmiles
Copy link

dlmiles commented Dec 10, 2023

@eskatos thanks for your comment on this concerning making the plugin work with Gradle configuration cache

When you say this could be a ConfigurableFileCollection are you aware the MavenUriResolver feature does need an absolutePath to the JAR file, but it also needs the original Maven style GAV coordinate information such as org.groupId:artifactId:jar:classifier:1.2.3.4 as to the reason why that specific JAR file was selected.

So unfortunately this Property is not just a standard list of file: scheme URL JARs list

However good news, after surveying the landscape for solutions and understanding of the problem it appears @ryandens has successfully produced a clean commit (in the past month) that understands the feature of this plugin.

ryandens@8956a7e
ryandens@f488e10

At this time and updated change-set https://github.com/dlmiles/gradle-xjc-plugin/tree/master is undergoing CI testing before being added to PR #47 (or its successor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants