Scaling up: weight for the suitability index can be set to 0

[SteeveEbener]

Current Behavior

You can set the weight to 0 for any of the suitability index

Expected Behavior

The weight can only be set between 1 and 10

Possible Solution

Limit the weight to values between 1 and 10

Steps to Reproduce

1. Go to the scaling up analysis
2. set the weight for one of the suitability factor to 0
3. click the compute button

You get an error message (see screenshot below) but you should not even be able to specify 0 in the first place

Detailed Description

None

[nicolasray]

I'm in favor of keeping the possibility for weight of zero: when you have a complex scaleup model with several suitability index, you may want to test alternatives results by skipping out one of the index. By indicating zero or its weight, this will do and avoids the need to re-enter it later on. Also, with the forthcoming Docker version (and later the command-line version of AccessMod), we'll be able to do parameter space exploration for uncertainty and sensitivity analyses, and the possibility of having wights of zero might be important there.

[SteeveEbener]

Skipping one of the index is currently done by unchecking it in the "select" column of the suitability factors table and I think that this makes more sense than setting a weight to "0". In any case, we should have only one way to do this.

If you still want to go for the possibility to set the weight to 0 then we will need to:

• Fix the current error when using "0" (see above)
• be able to change the weights to another value directly in the suitability factor table (issue Possibility to manually change the weights (Scaling up) #113

[nicolasray]

coming back to this old issue we should keep the possibility to use "0", and should indeed have the possibility to change the weights directly in the suitability factor table.