Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle predict kwargs in historical_forecasts() and backtest() #1294

Closed
hrzn opened this issue Oct 15, 2022 · 3 comments
Closed

handle predict kwargs in historical_forecasts() and backtest() #1294

hrzn opened this issue Oct 15, 2022 · 3 comments
Labels
good first issue Good for newcomers improvement New feature or improvement

Comments

@hrzn
Copy link
Contributor

hrzn commented Oct 15, 2022

No description provided.

@dennisbader dennisbader added the improvement New feature or improvement label Oct 27, 2022
@hrzn hrzn added the good first issue Good for newcomers label Nov 1, 2022
@hrzn hrzn unassigned dumjax Dec 15, 2022
@RayDanks
Copy link
Contributor

Hi, is this still outstanding with no assignee ? If so I'd like to take it as my first issue. I've already had a look through and familiarised myself with this particular issue, but will describe a bit more here once confirmed to be sure on my approach since it's my first contrib to this repo. Thanks :)

@hrzn
Copy link
Contributor Author

hrzn commented Jan 25, 2023

Hi @RayDanks and sorry for the late answer!
I think this should constitute a fairly good first issue to work on. Basically we need to accept predict_kwargs arguments in historical_forecasts() and backtest() and propagate them all the way to the calls to predict().

@madtoinou
Copy link
Collaborator

Implemented in #2050.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement New feature or improvement
Projects
Status: Released
Development

No branches or pull requests

5 participants