Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaled_circuits in ZNE should have a default noise scaling method #2640

Closed
purva-thakre opened this issue Jan 16, 2025 · 0 comments · Fixed by #2666
Closed

scaled_circuits in ZNE should have a default noise scaling method #2640

purva-thakre opened this issue Jan 16, 2025 · 0 comments · Fixed by #2666
Assignees
@purva-thakre
Labels
good first issue Good for newcomers zne Zero-noise extrapolation.
Milestone
0.44.0

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Jan 16, 2025 •
edited
Loading

Similar to the other top-level functions in ZNE, we should specify a non-optional scaling method

def scaled_circuits(
    circuit: QPROGRAM,
    scale_factors: list[float],
    scale_method: Callable[[QPROGRAM, float], QPROGRAM]  = fold_gates_at_random,
) -> list[QPROGRAM]:

mitiq/mitiq/zne/zne.py

Line 16 in 93e6ec3

def scaled_circuits(

Unit test for the default scaling method should be added in

mitiq/mitiq/zne/tests/test_zne.py

Line 590 in 93e6ec3

def test_two_stage_zne(

@purva-thakre purva-thakre added good first issue Good for newcomers zne Zero-noise extrapolation. labels Jan 16, 2025
@purva-thakre purva-thakre self-assigned this Feb 11, 2025
@purva-thakre purva-thakre mentioned this issue Feb 11, 2025
Merged
6 tasks
@purva-thakre purva-thakre added this to the 0.44.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purva-thakre purva-thakre

Labels
good first issue Good for newcomers zne Zero-noise extrapolation.
Projects
None yet
Milestone
0.44.0
Development

Successfully merging a pull request may close this issue.

Default scaling method in modularized ZNE function unitaryfund/mitiq
1 participant
@purva-thakre