Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align setup helper #3

Closed
haarchri opened this issue Jan 25, 2024 · 1 comment
Closed

align setup helper #3

haarchri opened this issue Jan 25, 2024 · 1 comment
Assignees
@humoflife
Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story point label needs-project Needs a project

Comments

@haarchri
Copy link
Member

What happened?

please align the test/setup.sh script
via makefile we building a configuration and during e2e target we install this configuration so we don't need this step:
https://github.com/upbound/configuration-vault/blob/main/test/setup.sh#L19-L23

please check for example:
https://github.com/upbound/configuration-gitops-flux/blob/main/test/setup.sh

Epic #

How can we reproduce it?

What environment did it happen in?
@haarchri haarchri added bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story point label needs-project Needs a project labels Jan 25, 2024
@humoflife
Copy link
Collaborator

Aligned and tested.

humoflife added a commit that referenced this issue Jan 25, 2024
@humoflife
update for git issue #3
bf9ca5e
@humoflife humoflife self-assigned this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humoflife humoflife

Labels
bug Something isn't working needs-epic-link Needs a link to an epic needs-points-label Needs a story point label needs-project Needs a project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humoflife @haarchri