Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate dependencies #203

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Update renovate dependencies #203

merged 5 commits into from
Nov 20, 2024

Conversation

kaessert
Copy link
Collaborator

@kaessert kaessert commented Nov 18, 2024

Description of your changes

Accumulation of recent renovate changes

How has this code been tested

e2e-tests

@kaessert
Copy link
Collaborator Author

/test-examples

@kaessert kaessert force-pushed the update-deps-renovate branch from d16eb4b to 3e40287 Compare November 18, 2024 19:55
@humoflife
Copy link

To test use make e2e. make e2e-tests does not seem to exist.

@humoflife
Copy link

Looks like this is installing an old version of uptest.

13:04:30 [ OK ] installing uptest /Users/markuss/upbound/dev/go/src/github.com/upbound/platform-ref-aws/.cache/tools/darwin_arm64/uptest-v0.13.0

Should it install uptest v1.2.0?

@humoflife
Copy link

Looks like this is installing an old version of crossplane cli.

13:04:34 [ .. ] installing Crossplane CLI v1.17.1

Should it install v1.18.0?

@humoflife
Copy link

As far as I can see, the tests succeed as expected within about 40 minutes.

@kaessert
Copy link
Collaborator Author

@humoflife The idea of this PR was merely to get into a habit of respecting and applying automated updates from renovate. Updating uptest, crossplane and so on are viable things but in my opinion we should first create a solid process and do the rest of the update on top of that. Ideally, all these changes should come from renovate in the end.

@ytsarev
Copy link
Member

ytsarev commented Nov 20, 2024

/test-examples

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaessert kaessert merged commit 6794251 into main Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants