From 39157b3b63740d51f1337925d6f9cf6678a59ae3 Mon Sep 17 00:00:00 2001 From: David Semakula Date: Tue, 11 Feb 2025 13:20:19 +0300 Subject: [PATCH] More idiomatic return types for metadata getters (#2398) * More idiomatic return types for metadata getters * Update changelog --- CHANGELOG.md | 1 + crates/metadata/src/lib.rs | 4 ++-- crates/metadata/src/specs.rs | 12 ++++++------ 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b7a4c17942..94a96b619c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Changed - Restrict which `cfg` attributes can be used ‒ [#2313](https://github.com/use-ink/ink/pull/2313) +- More idiomatic return types for metadata getters - [#2398](https://github.com/use-ink/ink/pull/2398) ## Added - Add feature flag to compile contracts for `pallet-revive` ‒ [#2318](https://github.com/use-ink/ink/pull/2318) diff --git a/crates/metadata/src/lib.rs b/crates/metadata/src/lib.rs index ceaed35db7..83aff86d11 100644 --- a/crates/metadata/src/lib.rs +++ b/crates/metadata/src/lib.rs @@ -123,8 +123,8 @@ impl InkProject { } /// Returns the metadata version used by the contract. - pub fn version(&self) -> &u64 { - &self.version + pub fn version(&self) -> u64 { + self.version } /// Returns a read-only registry of types in the contract. diff --git a/crates/metadata/src/specs.rs b/crates/metadata/src/specs.rs index 5607227321..1a45ed2a6b 100644 --- a/crates/metadata/src/specs.rs +++ b/crates/metadata/src/specs.rs @@ -431,8 +431,8 @@ where } /// Returns if the constructor is payable by the caller. - pub fn payable(&self) -> &bool { - &self.payable + pub fn payable(&self) -> bool { + self.payable } /// Returns the parameters of the deployment handler. @@ -450,8 +450,8 @@ where &self.docs } - pub fn default(&self) -> &bool { - &self.default + pub fn default(&self) -> bool { + self.default } } @@ -743,8 +743,8 @@ where &self.docs } - pub fn default(&self) -> &bool { - &self.default + pub fn default(&self) -> bool { + self.default } }