Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly wrong reorder logic between ordered lists and nesting unordered lists #11

Open
xBenChenx opened this issue Oct 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@xBenChenx
Copy link

xBenChenx commented Oct 31, 2024

Describe the bug

Ordered list cannot preserve the continuity in some common use scenarios.
The only way I found that can retain the continuity of the list is by inputting something like:

1. First item
2. Second item
3. Third item
    1. Indented item
    2. Indented item
4. Fourth item

Steps to reproduce

Just simply input text like:

1. First item
2. Second item
3. Third item
    - Indented item
    - Indented item
4. Fourth item

1. First item
2. Second item
3. Third item
    - [ ] Indented item
    - [ ] Indented item
4. Fourth item

1. First item
2. Second item
3. Third item
    3.1 Indented item
    3.2 Indented item
4. Fourth item

The version of Memos you're using.

v0.23.0

Screenshots or additional context

image
image

@xBenChenx xBenChenx added the bug Something isn't working label Oct 31, 2024
@johnnyjoygh johnnyjoygh transferred this issue from usememos/memos Nov 2, 2024
@raulriverarojas
Copy link

Hello Ben, I've been investigating this issue. In the demo version of the app the use cases you provided seem to be working correctly.
Screenshot from 2025-01-08 01-04-44
Screenshot from 2025-01-08 01-04-30
Screenshot from 2025-01-08 01-04-04

If I work on the assumption that memos parses and then restores the markdown using this gomark library.
I put together some tests to locally test the use case and I get proper results as well locally.

Screenshot from 2025-01-08 01-17-22

Screenshot from 2025-01-08 01-17-44
Can you still recreate the error on your end?

@raulriverarojas
Copy link

When I use the demo website for the long use case I do get weird behaviour
Screenshot from 2025-01-08 01-19-11
@boojack @johnnyjoygh
Locally this behavior is not happening for me as of Jan 8. I could be wrong as how memos uses gomark or the demo site could be using a old version gomark or this could be a memos issue instead of a gomark issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants