Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling doesn't work in menu screen until carousel is touched #42

Closed
b16tran opened this issue Nov 24, 2024 · 2 comments
Closed

Scrolling doesn't work in menu screen until carousel is touched #42

b16tran opened this issue Nov 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@b16tran
Copy link

b16tran commented Nov 24, 2024

Carousel selection isn't active until you interact with it by touching. Aka if I select Library, I expect to be able to start scrolling. I should always be able to scroll on the current tab selected.

Or by default the scroll knob should switch between the tabs on the left and when knob button pressed, goes into the carousel on the right from which you can scroll. Then if you click back, it goes back to the tabs for scrolling. There already is the little line on the left indicating the active tab, that can be extended to move over to above the album art when you enter the carousel context.

@BBaoVanC
Copy link
Member

I think what's happening is that the cursor is at the position where you last tapped. Then, if the component that should be scrolled by the dial doesn't happen to be under that spot, scrolling doesn't work. Perhaps nocturne-ui should override scroll wheel events and redirect them to whichever should be the main, scrollable component on the current page.

@BBaoVanC BBaoVanC moved this from Needs triage to Ready in Nocturne Triage Nov 24, 2024
@kenhayward
Copy link

Further to this, if you click back to get to recents from now playiong the scroll wheel works immediately, if you then click on library the scroll wheel no longer functions until you touch the screen - supporting the previous commenters point

@brandonsaldan brandonsaldan self-assigned this Dec 19, 2024
@brandonsaldan brandonsaldan added the bug Something isn't working label Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Nocturne Triage Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants