Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the MenuBar overflow example more realistic. #2994

Open
rolfsmeds opened this issue Nov 28, 2023 · 0 comments
Open

Make the MenuBar overflow example more realistic. #2994

rolfsmeds opened this issue Nov 28, 2023 · 0 comments

Comments

@rolfsmeds
Copy link
Contributor

The problem with the current docs sample is that the MenuBar is the direct child of a SplitLayout which directly adjusts its width. This hides the fact that in most cases, you need to give the MenuBar a width relative to its container (e.g. 100%), and also make sure the min-width is set to something that allows it to shrink (e.g. var(--lumo-size-m)).

We need to keep the SplitLayout in the sample to showcase the feature properly, but we should wrap the MenuBar in some other component – e.g. a HorizontalLayout – and provide the width and min-width appropriately. This will help developers figure out how to use the overflow feature.


If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant