Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit HTMLAttributes from Dialog and Notification #192

Closed
tomivirkki opened this issue Dec 19, 2023 · 1 comment · Fixed by #200
Closed

Omit HTMLAttributes from Dialog and Notification #192

tomivirkki opened this issue Dec 19, 2023 · 1 comment · Fixed by #200
Assignees
@web-padawan
Labels
DX

Comments

@tomivirkki
Copy link
Member

Similarly to #188, the majority of HTMLAttributes could be omitted from Dialog and Notification components since, like GridColumn, the host elements in the DOM are invisible.
@web-padawan
Copy link
Member

Note: same applies to ConfirmDialog, CookieConsent and LoginOverlay components.

@web-padawan web-padawan self-assigned this Dec 20, 2023
@web-padawan web-padawan added the DX label Dec 20, 2023
@web-padawan web-padawan mentioned this issue Dec 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web-padawan web-padawan

Labels
DX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: omit HTMLAttributes from non-visual component props vaadin/react-components
2 participants
@tomivirkki @web-padawan