From 7a7288b2922231a38fb02238b299525c074d9dc7 Mon Sep 17 00:00:00 2001 From: Gabi Ganam Date: Wed, 3 Apr 2024 02:03:31 +0300 Subject: [PATCH] Log unused module configuration entries that cause redis to abort (#132) Log unused module configuration entries that cause redis to abort on startup. Example: ``` 17797:M 31 Mar 2024 12:26:12.146 # Unused Module Configuration: module1.whatever 17797:M 31 Mar 2024 12:26:12.146 # Unused Module Configuration: module2.test 17797:M 31 Mar 2024 12:26:12.146 # Module Configuration detected without loadmodule directive or no ApplyConfig call: aborting ``` Signed-off-by: Gabi Ganam --- src/module.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/module.c b/src/module.c index 416506dc57..4fa96e9526 100644 --- a/src/module.c +++ b/src/module.c @@ -12109,6 +12109,13 @@ void moduleLoadFromQueue(void) { listDelNode(server.loadmodule_queue, ln); } if (dictSize(server.module_configs_queue)) { + dictIterator *di = dictGetSafeIterator(server.module_configs_queue); + dictEntry *de; + while ((de = dictNext(di)) != NULL) { + const char *moduleConfigName = dictGetKey(de); + serverLog(LL_WARNING, "Unused Module Configuration: %s", moduleConfigName); + } + dictReleaseIterator(di); serverLog(LL_WARNING, "Module Configuration detected without loadmodule directive or no ApplyConfig call: aborting"); exit(1); }