Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Color.compositeOver helper from compose.graphics #595

Open
okarmazin opened this issue Aug 28, 2024 · 1 comment
Open

Port Color.compositeOver helper from compose.graphics #595

okarmazin opened this issue Aug 28, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@okarmazin
Copy link
Contributor

okarmazin commented Aug 28, 2024

The existing Color.darkened arguably is the typical use case for compositing colors - designers sure do like their "5 % black over the background solid on hover". I think generalized Color.compositeOver is the next logical step.

https://github.com/androidx/androidx/blob/androidx-main/compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Color.kt#L561


Alternatively, Kobweb might benefit from porting the whole powerful Color system. If Kobweb already provides custom Color, it can as well have all the bells and whistles.

@okarmazin okarmazin added the enhancement New feature or request label Aug 28, 2024
@bitspittle bitspittle added this to the 1.1 milestone Aug 29, 2024
@bitspittle
Copy link
Collaborator

Thanks for the link to the Android color API!

I should definitely take a closer look at their code. I'll tag this with the 1.1 milestone because technically it isn't blocking anything and I haven't had any explicit requests for this or that color function, but that doesn't mean I wouldn't consider working on it or taking PRs for it before 1.0.

@bitspittle bitspittle added the good first issue Good for newcomers label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants