Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [REQUEST] - check for signature length on Transaction object instantiation #1781

Open
GrandinLuc opened this issue Feb 4, 2025 · 0 comments
Open

💡 [REQUEST] - check for signature length on Transaction object instantiation #1781

GrandinLuc opened this issue Feb 4, 2025 · 0 comments
Assignees
@GrandinLuc
Labels
Priority: Low Size: Small Type: Enhancement
Milestone
2.0.0-beta (Pre-R...

Comments

@GrandinLuc
Copy link
Collaborator

Summary

Update the method Transaction.of(body: TransactionBody, signature?: Uint8Array) in core/transaction/Transaction.ts to check for the signature length, either 65 or 130 depending if the transaction has been delegated or not and throw an error if the length is incorrect

Basic Example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrandinLuc GrandinLuc

Labels
Priority: Low Size: Small Type: Enhancement
Projects
None yet
Milestone
2.0.0-beta (Pre-Release)
Development

No branches or pull requests
2 participants
@GrandinLuc @victhorbi