Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we load brms automatically when bmm is loaded? #118

Closed
venpopov opened this issue Feb 21, 2024 · 2 comments · Fixed by #121
Closed

should we load brms automatically when bmm is loaded? #118

venpopov opened this issue Feb 21, 2024 · 2 comments · Fixed by #121
Labels
question Further information is requested
Milestone

Comments

@venpopov
Copy link
Owner

Related to this issue, which we resolved by having an explicit alias for save_pars: #110

Since brms is the main workhorse behind the bmm package, should we make it so that it is loaded automatically when loading bmm? This can be done by including it in depends rather than imports. brms does this with Rcpp.

This will avoid having issues like the one above in the future (and we can actually just remove the save_pars alias if we do this).

If we do this, this is what happens when you load bmm:

image

What do you think?

@venpopov venpopov added the question Further information is requested label Feb 21, 2024
@GidonFrischkorn
Copy link
Collaborator

I have been thinking about this, too. And generally I think there are many reasons to do so, especially because most of the post-processing is still relying on brms functions and if brms were loaded automatically users do not have to worry about loading brms to use these functions.

@venpopov
Copy link
Owner Author

OK, I'll add this and remove the save_pars alias

@venpopov venpopov added this to the 1.0.0 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants