Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend checkpoint functionality #131

Closed
venpopov opened this issue Feb 24, 2024 · 0 comments · May be fixed by #130
Closed

Extend checkpoint functionality #131

venpopov opened this issue Feb 24, 2024 · 0 comments · May be fixed by #130
Assignees
Labels
enhancement - new feature New user or developer feature
Milestone

Comments

@venpopov
Copy link
Owner

Now that we have checkpoint functionality #130, a few updates to it would be nice.

  1. Make it easier to recover interupted samples

Currently if you interrupt sampling, you can resume it easily by rerunning the model code. It would be nice to be able to check the results thought. This is already possible, but has to be handcoded additionally: donaldRwilliams/chkptstanr#2 (comment)

I'd like this to be easier. In the case where you specify a "stop_after" argument, I can just create the brmsfit object and return it via abort https://stackoverflow.com/a/57183881/3556519

But I need to figure out if we can do that if the sampling is interrupted manually. One possibility is to add a function "get_checkpoint_results", which only takes the path, rather than needing all original arguments (I would have to add this to my fork).

@venpopov venpopov added the enhancement - change functionality Change existing function behavior label Feb 24, 2024
@venpopov venpopov added this to the 1.0.0 milestone Feb 24, 2024
@venpopov venpopov self-assigned this Feb 24, 2024
@venpopov venpopov added enhancement - new feature New user or developer feature and removed enhancement - change functionality Change existing function behavior labels Feb 24, 2024
@venpopov venpopov linked a pull request Feb 28, 2024 that will close this issue
@venpopov venpopov modified the milestones: 1.0.0, Future Mar 9, 2024
Repository owner locked and limited conversation to collaborators Mar 26, 2024
@venpopov venpopov converted this issue into discussion #184 Mar 26, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement - new feature New user or developer feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant