Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] generalize the wrap and deg2rad functions for half-circular feature spaces (e.g. bar orientations) #224

Closed
GidonFrischkorn opened this issue May 31, 2024 · 0 comments · Fixed by #235
Assignees
Labels
enhancement - change functionality Change existing function behavior
Milestone

Comments

@GidonFrischkorn
Copy link
Collaborator

In some visual WM tasks participants are asked to remember the orientation of a bar. This feature space does only encompass a half-circle and thus we would have to adapt some of the helper function for the circular model. The user could just multiply the deviation in degrees with 2 and thereby rescale the feature space to a full-circle, but I wonder if we could handle that more elegantly with some of the helper function implemented in the package.

The other option would be to add some information in the article on continuous reproduction tasks that explains how to treat half-circular feature spaces when using the respective bmmodels

What do you think @venpopov?

@GidonFrischkorn GidonFrischkorn added this to the 1.1.0 milestone Jun 8, 2024
@GidonFrischkorn GidonFrischkorn self-assigned this Jun 9, 2024
@GidonFrischkorn GidonFrischkorn added the enhancement - change functionality Change existing function behavior label Jun 9, 2024
@GidonFrischkorn GidonFrischkorn linked a pull request Aug 14, 2024 that will close this issue
@GidonFrischkorn GidonFrischkorn linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement - change functionality Change existing function behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant