From 7ec174946a52ba79838ae349c48ebddbef995ca1 Mon Sep 17 00:00:00 2001 From: Jouni Siren Date: Tue, 6 Feb 2024 17:37:12 -0800 Subject: [PATCH] Clarity the status of rebuild_gbwt() --- src/gbwt_helper.hpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gbwt_helper.hpp b/src/gbwt_helper.hpp index 3dec9bcd444..cfb02d301a0 100644 --- a/src/gbwt_helper.hpp +++ b/src/gbwt_helper.hpp @@ -182,7 +182,6 @@ struct RebuildParameters { gbwt::size_type sample_interval = gbwt::DynamicGBWT::SAMPLE_INTERVAL; }; -// TODO: Use the new parallelization scheme. /// Rebuild the GBWT by applying all provided mappings. Each mapping is a pair /// (original subpath, new subpath). If the original subpath is empty, the /// mapping is ignored. If there are multiple applicable mappings, the first one @@ -210,6 +209,9 @@ struct RebuildParameters { /// /// NOTE: Threads may be reordered if there are multiple jobs. Old thread ids are /// no longer valid after rebuilding the GBWT. +/// +/// NOTE: This could use the ConstructionJob / MetadataBuilder scheme for +/// parallelization, but it would change the interface. gbwt::GBWT rebuild_gbwt(const gbwt::GBWT& gbwt_index, const std::vector& jobs, const std::unordered_map& node_to_job,