Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListItem-type component to launch external link via click or QR code #1811

Closed
blammit opened this issue Dec 20, 2024 · 1 comment
Closed

Add ListItem-type component to launch external link via click or QR code #1811

blammit opened this issue Dec 20, 2024 · 1 comment
Assignees
@blammit
Labels
medium_prio
Milestone
Version 1.1.0

Comments

@blammit
Copy link
Contributor

blammit commented Dec 20, 2024

See discussion here: https://victrondevelopment.slack.com/archives/C06EVSJDR3K/p1730988149525699

The list item should be different on Wasm vs Device displays:

  • On Wasm, show the title and "Open Link" to open the url
  • On Device, show the title and a QR code, and an extra description
@blammit blammit added this to the Version 1.1.0 milestone Dec 20, 2024
@blammit blammit self-assigned this Dec 20, 2024
blammit added a commit that referenced this issue Jan 7, 2025
@blammit
ListItem: rework layout and add bottomContentSizeMode
a42f443 
Allow the bottom content horizontal sizing to be customized:

- 'stretch' size mode: bottom content spans the full width of the list
item (as per existing behavior).
- 'compact' size mode: the bottom content spans from the list item's
left side, to the edge of the item's right-hand content.

The 'compact' size is useful if the right-hand content is taller than
the primaryLabel text; in this case, the caption text should wrap at
the edge of the right-hand content, instead of dropping below it.

Use a GridLayout with row and column spans to make this layout more
easily configurable.

Part of #1811
blammit added a commit that referenced this issue Jan 7, 2025
@blammit
Add ListLink component to show either QR code or link button
81d378e 
Part of #1811
blammit added a commit that referenced this issue Jan 7, 2025
@blammit
ListItem: rework layout and add bottomContentSizeMode
63a1d89 
Allow the bottom content horizontal sizing to be customized:

- 'stretch' size mode: bottom content spans the full width of the list
item (as per existing behavior).
- 'compact' size mode: the bottom content spans from the list item's
left side, to the edge of the item's right-hand content.

The 'compact' size is useful if the right-hand content is taller than
the primaryLabel text; in this case, the caption text should wrap at
the edge of the right-hand content, instead of dropping below it.

Use a GridLayout with row and column spans to make this layout more
easily configurable.

Part of #1811
blammit added a commit that referenced this issue Jan 7, 2025
@blammit
Add ListLink component to show either QR code or link button
4092b36 
Part of #1811
blammit added a commit that referenced this issue Jan 8, 2025
@blammit
Add ListLink component to show either QR code or link button
9c088ce 
Part of #1811
blammit added a commit that referenced this issue Jan 8, 2025
@blammit
ListItem: rework layout and add bottomContentSizeMode
a4c7892 
Allow the bottom content horizontal sizing to be customized:

- 'stretch' size mode: bottom content spans the full width of the list
item (as per existing behavior).
- 'compact' size mode: the bottom content spans from the list item's
left side, to the edge of the item's right-hand content.

The 'compact' size is useful if the right-hand content is taller than
the primaryLabel text; in this case, the caption text should wrap at
the edge of the right-hand content, instead of dropping below it.

Use a GridLayout with row and column spans to make this layout more
easily configurable.

Part of #1811
blammit added a commit that referenced this issue Jan 8, 2025
@blammit
Add ListLink component to show either QR code or link button
8edf37c 
Part of #1811
MikeTrahearn-Qinetic pushed a commit that referenced this issue Jan 9, 2025
@blammit @MikeTrahearn-Qinetic
ListItem: rework layout and add bottomContentSizeMode
03c1aa2 
Allow the bottom content horizontal sizing to be customized:

- 'stretch' size mode: bottom content spans the full width of the list
item (as per existing behavior).
- 'compact' size mode: the bottom content spans from the list item's
left side, to the edge of the item's right-hand content.

The 'compact' size is useful if the right-hand content is taller than
the primaryLabel text; in this case, the caption text should wrap at
the edge of the right-hand content, instead of dropping below it.

Use a GridLayout with row and column spans to make this layout more
easily configurable.

Part of #1811
MikeTrahearn-Qinetic pushed a commit that referenced this issue Jan 9, 2025
@blammit @MikeTrahearn-Qinetic
Add ListLink component to show either QR code or link button
cb5e383 
Part of #1811
@blammit
Copy link
Contributor Author

blammit commented Jan 12, 2025

PR merged.

@blammit blammit closed this as completed Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blammit blammit

Labels
medium_prio
Projects
None yet
Milestone
Version 1.1.0
Development

No branches or pull requests
1 participant
@blammit