Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show QR/Link code to add GX to VRM #1856

Open
jepefe opened this issue Jan 16, 2025 · 7 comments
Open

Show QR/Link code to add GX to VRM #1856

jepefe opened this issue Jan 16, 2025 · 7 comments
Assignees
Labels
blocked Waiting for venus-platform or other support high_prio High priority
Milestone

Comments

@jepefe
Copy link

jepefe commented Jan 16, 2025

NOTE: before implementing this there are two other changes that need to be completed:

  1. change to venus-platform by Rein (add productid) DONE.
  2. change url API on VRM to accept productid rather than deviceType

This allows to register the GX in VRM without having to connect with VC via Wifi/Bluetooth.

This url will open the VRM add installation page if the GX is not registered yet, otherwise it will open the installation page.

Exact URL to be confirmed by Alex after VRM has been updated. Discussion in Slack here.

Old proposal:

"https://vrm.victronenergy.com/login?installationIdentifier=" + vrmId + "&device=" + deviceType

deviceType = "ccgx" // Color Control GX
deviceType = "vgx" // Venus GX
deviceType = "ogx" // Octo GX
deviceType = "egx" // EasySolar-II GX
deviceType = "mgx" // MultiPlus-II GX
deviceType = "ekranogx" // Ekrano GX
deviceType = "cerbogx" // Cerbo GX
@mpvader mpvader added this to the Version 1.1.0 milestone Jan 16, 2025
@mpvader mpvader added high_prio High priority and removed low_prio labels Jan 16, 2025
@blammit
Copy link
Contributor

blammit commented Jan 19, 2025

This can go on the "VRM" page (between VRM Portal ID and Log interval), with "Register installation" as the title text.

Implementation note: use the ListLink component to provide this.

@DanielMcInnes DanielMcInnes self-assigned this Jan 21, 2025
@mpvader mpvader added the blocked Waiting for venus-platform or other support label Jan 21, 2025
@mpvader
Copy link
Contributor

mpvader commented Jan 21, 2025

I've updated the first message to the outcome of the discussion wrt how to tackle this + marked it as blocked since its awaiting some changes elsewhere.

@mr-manuel
Copy link
Collaborator

With my current modifications com.victronenergy.platform/Device/Model is added, if that is of relevance.

Output:

  • Cerbo GX
  • Ekrano GX
  • MultiPlus-II

https://github.com/victronenergy/venus-platform/blob/043d7a8768559ed954cba9c69ecd8808c9efae5e/src/application.cpp#L681-L684

ReinvdZee added a commit to victronenergy/venus-platform that referenced this issue Jan 21, 2025
@ReinvdZee
Copy link
Contributor

Changes pushed and on the todo.
The product ID will be published on com.victronenergy.platform/Device/ProductId.

jhofstee added a commit to victronenergy/meta-victronenergy that referenced this issue Jan 22, 2025
@mpvader
Copy link
Contributor

mpvader commented Jan 30, 2025

This is now waiting for the vrm api to have been updated

@AlexImb
Copy link
Member

AlexImb commented Jan 30, 2025

Exact URL to be confirmed by Alex

URL structure will be: https://vrm.victronenergy.com/login?installationIdentifier=" + vrmId + "&productId=" + deviceType

Implementation will be live next week.

@AlexImb
Copy link
Member

AlexImb commented Feb 5, 2025

The VRM change is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for venus-platform or other support high_prio High priority
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants