From 4d0150c78aaadf5180a0f2c1bbb17947f8ef0894 Mon Sep 17 00:00:00 2001 From: Priyank Gupta Date: Fri, 26 Feb 2016 18:05:19 +0530 Subject: [PATCH] Fix failing spec by upgrading capybara to 2.5, add development dependency capybara-screenshot, replace deprecated SingleSpaceBeforeFirstArg with SpaceBeforeFirstArg for hound --- .hound.yml | 2 +- spec/support/capybara.rb | 3 +++ spree_related_products.gemspec | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.hound.yml b/.hound.yml index 6d33c7f0..b6aaf167 100644 --- a/.hound.yml +++ b/.hound.yml @@ -8,7 +8,7 @@ Documentation: Enabled: false # Neatly aligned code is too swell. -SingleSpaceBeforeFirstArg: +SpaceBeforeFirstArg: Enabled: false # Don't mess with RSpec DSL. diff --git a/spec/support/capybara.rb b/spec/support/capybara.rb index ac5eee46..a170eba4 100644 --- a/spec/support/capybara.rb +++ b/spec/support/capybara.rb @@ -1,10 +1,13 @@ require 'capybara/rspec' require 'capybara/rails' require 'capybara/poltergeist' +require 'capybara-screenshot/rspec' RSpec.configure do |config| Capybara.javascript_driver = :poltergeist + Capybara.save_and_open_page_path = ENV['CIRCLE_ARTIFACTS'] if ENV['CIRCLE_ARTIFACTS'] + Capybara.register_driver(:poltergeist) do |app| Capybara::Poltergeist::Driver.new app, js_errors: true, timeout: 30 end diff --git a/spree_related_products.gemspec b/spree_related_products.gemspec index 636a0ddb..545fe942 100644 --- a/spree_related_products.gemspec +++ b/spree_related_products.gemspec @@ -29,7 +29,8 @@ Gem::Specification.new do |s| s.add_development_dependency 'ffaker' s.add_development_dependency 'rspec-rails', '~> 3.1.0' s.add_development_dependency 'sqlite3', '~> 1.3.10' - s.add_development_dependency 'capybara', '~> 2.4.4' + s.add_development_dependency 'capybara', '~> 2.5' + s.add_development_dependency 'capybara-screenshot', '~> 1.0.11' s.add_development_dependency 'poltergeist', '~> 1.5.0' s.add_development_dependency 'shoulda-matchers', '~> 2.5' s.add_development_dependency 'simplecov', '~> 0.9.0'