Script caching isn't working properly

[ctrlaltdavid]

Checking whether script file has changed and needs to be redownloaded (instead of just using whatever's in cache).
Respecting script file expiry dates (i.e., redownload if expired).
Cache-busting.

[digisomni]

This happens with models too! Generally requests and caching aren't really checked I think according to the HTTP spec.

[HifiExperiments]

I’ve looked into this before and I think the cachebusting etc is necessary because we force our HTTP requests to use qnetworkrequest::PreferCache in https://github.com/vircadia/vircadia/blob/ec1c8f2b87187c5be8f5d208b539b6848ebd97b4/libraries/networking/src/HTTPResourceRequest.cpp

the default value, PreferNetwork, might just solve a lot of these problems: https://doc.qt.io/qt-5/qnetworkrequest.html#CacheLoadControl-enum

[HifiExperiments]

#92

[daleglass]

Dev meeting: Need to check what exactly does PreferNetwork do: does it go to the server every time to check the timestamp?

[daleglass]

Also, do we store expiration times in our cache?

[HifiExperiments]

it sounds like even PreferCache respects expiry times, but I guess the only way to find out is to try it

I would assume hifi originally chose PreferCache because it means fewer network requests to check timestamps, but the trade off seems like it’s not worth it. or perhaps if the extra requests are too much, we have a “developer mode” that lets you temporarily switch to PreferNetwork while testing models/scripts, but most people still use PreferCache. there’s already a switch in the code, but the alternative is AlwaysNetwork, which doesn’t seem like what we want either

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Hello! Is this still an issue?

[stale]

Hello! Is this still an issue?