-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of batch translate #101
Comments
Okay I added this in my fork |
You can spilt batch contents with line break, and translate in one request. In @AidanWelch 's fork, I see |
it's not secure. line breaks sometimes will be added or removed after translated. be careful when you are using line breaks. |
It's just a suggestion. Although I can't 100% guarantee, I have been requesting in such method for a while and never meet unexpected adding or removing line break. |
It is now updated to just one request. |
But I should note, not by splitting with line breaks, as that has no guarantee of working in all cases. Instead it is just utilizing fully the batch request API that @shtse8 mapped out |
@vitalets do you plan to add batch translation? |
I think batching via concatenation into single string (as suggested above) should stay in userland, as there are edge cases that library can't be responsible for. |
I want to pass an array of string for translation. Could you add support of it?
The text was updated successfully, but these errors were encountered: