Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of []int to plot axis types #178

Closed
2 tasks
ArtemkaKun opened this issue Oct 21, 2023 · 0 comments · Fixed by #181
Closed
2 tasks

Add support of []int to plot axis types #178

ArtemkaKun opened this issue Oct 21, 2023 · 0 comments · Fixed by #181
Assignees

Comments

@ArtemkaKun
Copy link
Contributor

Describe the feature

Currently plot sumtypes XType and YType correspondingly represent values of the X and Y axis have definition []f64 | []string. These sumtypes also should support []int type

Use Case

For example, Is V still fast? values are ints, and when someone wants to use it for plot they need to be converted to []f64 which adds complexity to the code and hits performance.

Proposed Solution

type AxisType = []f64 | []string | []int

pub type XType = AxisType

pub type YType = AxisType

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Version used

6904d72

Environment details (OS name and version, etc.)

Not related

@ulises-jeremias ulises-jeremias self-assigned this Oct 21, 2023
@ulises-jeremias ulises-jeremias linked a pull request Oct 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants