Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Deprecate this module in favour of foreman/puppet #69

Open
bastelfreak opened this issue Aug 18, 2018 · 13 comments
Open

Deprecate this module in favour of foreman/puppet #69

bastelfreak opened this issue Aug 18, 2018 · 13 comments
Labels
needs-feedback Further information is requested

Comments

@bastelfreak
Copy link
Member

Hi!,

I would like to deprecate this module in favour of https://github.com/theforeman/puppet-puppet
The foreman team puts so much effort into their modules. Their amount of unit and acceptance tests is so high. Also upgrades between versions are tested and supported. @voxpupuli/collaborators let me know what you all think about it.

@bastelfreak bastelfreak added the needs-feedback Further information is requested label Aug 18, 2018
@ekohl
Copy link
Member

ekohl commented Aug 20, 2018

I am biased because I also work on the foreman one, but I'm quite happy with the state it's in. I'd be happy with it being a recommended module from a Voxpupuli point of view. If there are blockers to its adoption, please let us know :)

@tuxmea
Copy link
Member

tuxmea commented Aug 20, 2018

We have even customers who like this module due to its lack of complexity.

@binford2k
Copy link
Member

@raphink do you have feedback on this topic? Should the puppetserver config types be their own module, ported to the foreman module, something else?

@raphink
Copy link
Member

raphink commented Aug 22, 2018

@binford2k I personally don't really have an opinion. We gave this module to @voxpupuli because we didn't use it anymore since we switched to a dockerized Puppet infrastructure. The type could be in a module on its own, but then why not just keep this module as it is?

@dhollinger
Copy link
Member

dhollinger commented Aug 22, 2018

@binford2k Does the puppetserver_config type offer something that puppetlabs-hocon, puppetlabs-puppet_authorization, puppetlabs-inifile, or theforeman-puppet don't already offer for puppetserver?

@raphink
Copy link
Member

raphink commented Aug 22, 2018

Probably not. It would cover the same scope as puppetlabs-hocon, which didn't exist at the time, but it uses Augeas to do the work. Unfortunately, the HOCON format is pretty hard to model properly in Augeas, which means puppetlabs-hocon probably does a better job at it.

@roidelapluie
Copy link
Member

It looks like we well not reach consensus here so I'd keep this module.

@ekohl
Copy link
Member

ekohl commented Oct 19, 2019

I'd like to reopen the discussion. There has been no significant work on this module and nobody is stepping up.

@bastelfreak
Copy link
Member Author

I'm still 👍 for deprecating it. Personally I've no interest in maintaining it since I use theforeman/puppet. Also it seems like nobody else want's to work on it.

@ekohl
Copy link
Member

ekohl commented Feb 19, 2020

It's becoming a burden to modulesync. Given there's been no effort in fixing the broken tests in master for a while (#75), I'm proposing that unless someone steps up to maintain this module is deprecated. I'd like to set the April 1st date for this, but since that sounds like a joke I'm proposing March 31st

@bastelfreak
Copy link
Member Author

@ekohl I agree to 100%. I dont see a purpose in maintaining it.

@oranenj
Copy link

oranenj commented Feb 19, 2020

@ekohl this issue has been open long enough that I don't think anyone would complain if you just did the deprecation right away.

I use foreman/puppet too, so no objections to this.

@ekohl
Copy link
Member

ekohl commented Apr 6, 2020

So even with a few day extra, I haven't seen anyone step up to maintain this so I'd like to move forward with deprecation.

kBite added a commit to kBite/puppet-puppetserver that referenced this issue Jul 22, 2020
kBite added a commit to kBite/puppet-puppetserver that referenced this issue Jul 22, 2020
kBite added a commit to kBite/puppet-puppetserver that referenced this issue Jul 22, 2020
ekohl added a commit that referenced this issue Jul 22, 2020
(#69) add deprecation hint to README.md
ekohl added a commit to ekohl/modulesync_config that referenced this issue Jul 22, 2020
Per voxpupuli/puppet-puppetserver#69 this
module is deprecated. While some people wanted to see it maintained,
nobody stepped up. There is no point in trying to modulesync it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants