Improve Fuzzy matching

[Heartman30044]

What version of B2S Server are you using?

2.1.3

Can the bug depend on a certain VPX or VPM version?

latest vesions as of this date

Describe the bug 🐞

I had 2.1.2 installed and the following was working properly:

Cosmic Princess (Stern - 1979).vpx
Cosmic Princess (Stern 1979).directb2s

I then updated to 2.1.3 and the Directb2s is now longer found. If I change the name to exactly match, it works as expected.

Looking at the B2STableSettings. it doesn't seem to matter whether the global setting is set or not.

Hopefully this is enough information. If not, let me know. The table and backglass are in a separate folder with a unique B2STableSettings and Screenres files.

Thanks

Expected behavior and solution proposal ✅

I followed my update process that I have done before. 2.1.2 was installed. I copied the 2.1.3 files over and reran the register exefile.

Relevant log output

[JockeJarre]

Hi, the "fuzzy" matching was updated in 2.1.3 to only "fuzzy" match after the last ")"
so the names has to match fully like "Cosmic Princess (Stern - 1979)" and then be whatever you want...

The problem was that the old "fuzzy" match used the dos 8 char short names, which means it matched far to much.

[Heartman30044]

Ok, Thanks for the reply - not sure I like that, but it is what it is. I will just have to go through all the tables and update the B2S filenames.... I understand what the fuzzy matching is now. Since I have all the tables in their own folder, the fuzzy matching (the old way) never gave me a problem.

Thanks.

[JockeJarre]

Thanks for understanding! We ALWAYS had problems with users where the old logic made it find the wrong backglass. (as long as it matched 4-5 chars it was happy)
I also understand why you never had a problem, but I hope to be able to keep the new way of working.
Reason for searching for the last ")" is to make sure the same table and brand but with different author or version number to match.

[JockeJarre]

before you change all, I might have an idea how it can be solved. Let me try it out...

[JockeJarre]

There is a new build available under actions (you need to login as a free user to reach them)
Can you please test?

[Heartman30044]

I will, but it might not be until later today. This afternoon is pretty booked with other activities. Thanks.

[Heartman30044]

Finally did some testing. I'm using PinupPopper Autorecord to do the backglass captures. I started by deleting all of the current ones and recaptured using the 2.1.3 version. Of the 50 or so that were captured, about 15-20 were not correct, so the names must not be compatible with the new method in 2.1.3.

I installed the test version that you provided and watched as it tried to do the ones that did not work before. All of the ones that I saw, loaded the backglass as I have named. However, the recording only seemed to capture every other one. I added some more delay the end game processing and that seems better.

Overall, I would say the new test version works better in my installation. However, I don't want the change if it still would cause issues with the others that wanted the change in the first place. I can change the names if needed.

Thanks.

[JockeJarre]

I would say, that now we have best of both worlds. I have removed the old wrong way and it would work for you even with all in one folder...
So we can close the issue now?

[Heartman30044]

I would say yes - thanks for all the hard work.

[JockeJarre]

Thanks

[Heartman30044]

If I can ask - and you see this, what is the new way of doing the matching. The reason is that in the following example it is using a version I wasn't expecting:

Table name:
Pabst Can Crusher, The (Stern 2016).vpx

Backglass I wanted to use:
Pabst Can Crusher (Stern 2016) full dmd.directb2s

Seems to always use this one (Doesn't seem to matter what prefix I put on it):
a-Pabst Can Crusher (Stern 2016).directb2s

Just wondering...
Thanks

[Heartman30044]

Sorry for all the trouble, but just a suggestion. Could you use the old way (the 8.3 name, as I understand). If you use a function to see there is more than one file that fits that method, then use the new method with the ")" as the dividing mark. I was just trying to update a new backglass using the method I normally use (adding a prefix to the undesired one), and it was always being used. Thanks for all your work on this.

…

On Wed, Feb 5, 2025 at 12:32 PM Jarr3 ***@***.***> wrote: Thanks — Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWGHTGF3U4KGFYRX4SCITMD2OJDL7AVCNFSM6AAAAABWM6PP5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZXGU4DEOJXG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JockeJarre]

I will check your new example