rmilter fails to start using default debian config

[sbarakat]

Hi
Thank you for creating what looks to be a great alternative to what is already out there!

I've been attempting to get setup using the available deb packages. Initially I ran into not having any config files which I see is now fixed in e3d3d66, however I am running into the issue below when starting rmilter:

rmilter[2725]: main: starting rmilter version 1.6.7
rmilter[2726]: Unable to open pidfile /run/rmilter.pid

I believe this is due to insufficient permissions on /run/ when starting up. It looks to me that rmilter.conf.sysvinit should have the pidfile set to /run/rmilter/rmilter.pid instead of /run/rmilter.pid.

The upstart script creates the correct permissions on the /run/rmilter/ directory for the pid file to be created under there. Also the path to the pid file should possibly be updated in the rmilter.init file too.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[vstakhov]

Should be fixed now (the init script did the proper job btw).

[sbarakat]

Great! thanks for looking into it straight away

With the config change in b71562e the pid file get created correctly in /run/rmilter/rmilter.pid and rmilter starts fine with upstart, however it still looks broken with system v:

$ /etc/init.d/rmilter start
$ ps aux | grep rmilter
_rmilter  6608  0.0  1.0 216900 10952 ?        Ssl  11:00   0:00 /usr/sbin/rmilter -c /etc/rmilter.conf.sysvinit
root      6615  0.0  0.0  11740   940 pts/0    S+   11:00   0:00 grep --color=auto rmilter
$ /etc/init.d/rmilter stop
No rmilter found running; none killed.
$ ps aux | grep rmilter
_rmilter  6608  0.0  1.0 216900 10952 ?        Ssl  11:00   0:00 /usr/sbin/rmilter -c /etc/rmilter.conf.sysvinit
root      6621  0.0  0.0  11740   936 pts/0    S+   11:01   0:00 grep --color=auto rmilter
$ cat /run/rmilter/rmilter.pid 
6608
$ cat /run/rmilter.pid
cat: /run/rmilter.pid: No such file or directory

Changing rmilter.init to this solves the problem:
SSD="start-stop-daemon --pidfile $RUNDIR/$NAME.pid --name rmilter"

[vstakhov]

Should be fixed right now

[sbarakat]

Perfect 👍