Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Use ES6 target instead of ES5 #29

Open
adityasharma7 opened this issue May 19, 2021 · 0 comments
Open

Use ES6 target instead of ES5 #29

adityasharma7 opened this issue May 19, 2021 · 0 comments

Comments

@adityasharma7
Copy link

Hi team,

First of all, kudos to you all for contributing such an amazing library.

I am using it in Ionic 5/ Angular apps to generate elastic search queries. I noticed the following warning when using it

[ng] Warning: /xxxx.ts depends on 'storefront-query-builder'. CommonJS or AMD dependencies can cause optimization bailouts.
[ng] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

I think if we build it as ES6 modules instead of ES5, we have the advantage of having tree shaking which can help to reduce the JavaScript payload.

WDYAT?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant