feat[test]: add hevm harness for venom passes #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4460 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 119 119
Lines 16931 16931
Branches 2865 2865
=======================================
Hits 15593 15593
Misses 919 919
Partials 419 419 ☔ View full report in Codecov by Sentry. |
charles-cooper
force-pushed
the
feat/venom/hevm-equivalence
branch
from
ab27245 to
1e02f4c
Compare
HodanPlodky
reviewed
Feb 1, 2025
| self.updater._update(inst, "eq", [operands[1], IRLiteral(never)]) | ||
| # canary: | ||
| # self.updater._update(inst, "eq", [operands[1], IRLiteral(lo)]) |
There was a problem hiding this comment.
Do you want to leave this here or could be revert this?
There was a problem hiding this comment.
I'll leave it for people to review then remove
tests/hevm.py
Outdated
| ctx = parse_from_basic_block(venom_source_code) | ||
|
|
||
| num_calldataloads = 0 | ||
| num_return_values = 0 |
There was a problem hiding this comment.
you could remove this one right (num_return_values)?
There was a problem hiding this comment.
Yea, looks like it
harkal
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
draft, add hevm equivalence checking for venom optimizations
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture