pass plugin : be able to enforce variable number of lower, upper, number, symbols (patch proposed)

[Daggett-]

Hi all,

I needed to make the pass plugin able to enforce a configurable number of lower/upper/number/symbol chars.

So I modified this plugin and did a patch but I don't know how to include nor submit it there.

I also corrected french translation of this plugin.

How can I submit my patch ?

Bye for now,
Dag

[horfic]

Here you go: https://help.github.com/articles/creating-a-pull-request

thanks for the work

[Daggett-]

Thanks,

I created a pull request for that.

Bye for now,
Dagg

[Daggett-]

If you accept it, can my real name be in the credits instead of my login name ?

What should I do for that ?

Bye for now,
Denis Chupau

[horfic]

regarding your name, no i can't, but you can set your name in github here: https://github.com/settings/profile

i will test your code changes tomorrow.

[Daggett-]

I didn't find any names or credits for all the code of thoses useful plugins : is this a decision you made for the project ?

Thanks for the testings.

There may be some functionality missing : I didn't take care of the display things linked to thoses new variable parameters aside from error messages in english and french.

I mean at least the "secure password" meter and other error messages translations may be inaccurate or missing.

Perhaps it could be interesting to put those translations on Transifex under RoundCube's project ?

Bye for now,
Denis

[horfic]

the project got currently no license and no credits, although this will change with the next upcoming release of it.

so for the time beeing it is as is.

Regarding credits for the code, except of one patch for aliases and the languages, the code comes from me.

PS: Except your new pull request.

[Daggett-]

Hi,

how did your tests go ?

I think my code may miss to update things for the "strength progress bar" thing : can somone confirm this and implement the missing bit ?
(I don't use that strength bar and don't feel comfortable about modifying JS).

[horfic]

testing went well, so we will use it, but i need to update the strength progress bar first, so that both things are working in harmony.

[jult]

Sadly, all this makes no sense. Throw out those ridiculously complex requirements, and require only one, namely LENGTH!
As a CISSP and CEH I can assure you, those complex hard to remember passwords are useless. What you want is either proper 2FA and/or lengthy passphrases. Don't believe me? Do try this.
A password like "somestupidreallydumbbutlongpass" is waaaay better than "g76^%_hgK".