Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript implementation #45

Open
jrhender opened this issue Feb 16, 2022 · 5 comments
Open

Typescript implementation #45

jrhender opened this issue Feb 16, 2022 · 5 comments

Comments

@jrhender
Copy link

Is anyone aware of any efforts towards typescript implementation of this spec? I see that none have been added to this PR #36 but thought I would ask in case there are any, even partial, TS implementations out there. Asking because EnergyWeb is considering writing one and would be glad to collaborate 😄

@mirceanis
Copy link
Collaborator

There is some work already done by the good folks from 3box/ceramic: https://github.com/ceramicnetwork/jsonld-eip712-signatures
And there is a partial implementation of the types generation algorithm from serto: https://github.com/SertoID/eip-712-types-generation

@jrhender
Copy link
Author

Thank you @mirceanis ! @haardikk21 @nickreynolds , do you think it would make sense to add your respective work to #36 ? I can add them to the PR if you think it would appropriate to list them there.

@mirceanis
Copy link
Collaborator

@jrhender I did not get a chance to test those implementations.
If you put them through your tests and they match the spec, then you can surely add them there.

@haardikk21
Copy link
Contributor

Thank you @mirceanis ! @haardikk21 @nickreynolds , do you think it would make sense to add your respective work to #36 ? I can add them to the PR if you think it would appropriate to list them there.

Our version isn't fully up to the latest spec, and likely fails a couple test vectors. We have currently deprioritized this work internally, so we cannot commit to completing it anytime soon.

If you'd like to make PR's to our repo and merge it in #36, that would be amazing!

@nickreynolds
Copy link

@jrhender fine with me if you'd like to include ours here. It's not currently being worked on and wasn't tested heavily, but I might pick it up again soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants