Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch invoker to authorizedParty #20

Open
cwebber opened this issue Oct 30, 2018 · 5 comments
Open

Switch invoker to authorizedParty #20

cwebber opened this issue Oct 30, 2018 · 5 comments

Comments

@cwebber
Copy link
Contributor

cwebber commented Oct 30, 2018

invoker is a bit confusing because it makes the capability document look like an invocation when you're reading it. @dmitrizagidulin suggests authorizedParty which is closer to the oauth group does

@danfinlay
Copy link

I think “recipient” also works pretty well.

@dlongley
Copy link
Contributor

We want to be able to distinguish invoker from delegator, so if we change the name, we should change both, perhaps to: authorizedInvoker and authorizedDelegator. I'm also not sure how confusing it is ... and whether or not a change is really necessary must now be weighed against the cost of changing what is already being deployed today.

@danfinlay
Copy link

I agree with not breaking existing things, just riffing on the wording because having just written up the type, invoker stood out as a bit awkward :)

@dlongley
Copy link
Contributor

dlongley commented Jul 1, 2019

We are likely going to change invoker to authorizedInvoker and delegator to authorizedDelegator to avoid confusion. The reason for moving forward with the change is that specifying who delegated a capability via the delegator property is useful -- and this would be in conflict with using it to mean who is authorized to further delegate. Since we'd be changing to use authorizedDelegator it would make sense to align invoker by changing it to authorizedInvoker even though we don't have a use case for invoker at this time. We will likely make this change in our ocapld.js implementation very shortly.

cc: @cwebber

@dlongley
Copy link
Contributor

dlongley commented Jul 1, 2019

We're going to experiment a bit more with our implementation per the last comment -- it may turn out to be more confusing in some ways to use authorizedDelegator than just delegator -- based on the fact that you need to check parentCapability.authorizedDelegator when verifying, not capability.authorizedDelegator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants