Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build card decks #30

Open
nicdford opened this issue Dec 12, 2019 · 3 comments
Open

Build card decks #30

nicdford opened this issue Dec 12, 2019 · 3 comments
Labels
Component Is a component to be built Overview

Comments

@nicdford
Copy link
Contributor

nicdford commented Dec 12, 2019

image

@nicdford nicdford added the Component Is a component to be built label Dec 12, 2019
@nicdford nicdford added this to the Future Release milestone Dec 12, 2019
@nicdford nicdford self-assigned this Feb 26, 2020
@nicdford
Copy link
Contributor Author

nicdford commented Mar 3, 2020

Do we want to do anything unique for handling multiple values of the same type? For example, if someone included multiple website addresses, should it just create another line with an icon or do something else? This also would apply to any other contact info types (phone, address, email, etc).

@nicdford nicdford modified the milestones: Version 0.4.0, Future Release Mar 4, 2020
@nicdford nicdford removed their assignment Mar 4, 2020
@nicdford
Copy link
Contributor Author

nicdford commented Mar 4, 2020

Going to call this one good for now, need to revisit in the future once we need to add the rest of the features. I didn't create an individual PR for this, it's all just merged into master directly.

https://washingtonstateuniversity.github.io/wsu-web-design-system/components/dist/content-card/content-card.html

@nicdford nicdford added Good for now Label for components that are largely good at the moment. and removed Needs UI/UX Discussion labels Mar 4, 2020
@nicdford
Copy link
Contributor Author

nicdford commented Mar 10, 2020

Feedback from group

Link behaviors

  • Need to figure out how to handle linking in cards

Images in news feed

  • Align images to right and/or left
  • Fallback image

@nicdford nicdford removed the Good for now Label for components that are largely good at the moment. label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component Is a component to be built Overview
Projects
None yet
Development

No branches or pull requests

1 participant