Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin doesn't provide JSON output when webpack is run with --json #77

Open
larsmoa opened this issue Dec 19, 2019 · 1 comment · May be fixed by #110
Open

Plugin doesn't provide JSON output when webpack is run with --json #77

larsmoa opened this issue Dec 19, 2019 · 1 comment · May be fixed by #110
Labels
enhancement New feature or request

Comments

@larsmoa
Copy link

larsmoa commented Dec 19, 2019

Plugin uses console.error and console.log rather than webpack builtin logger. This causes the plugin to produce plain text output even when running webpack with parameter --json.

I suggest usage of console is replaced with the logger from webpack to avoid this.
@xtuc
Copy link
Member

xtuc commented Jan 28, 2020

Good idea! Would you mind sending a PR to fix that?

@xtuc xtuc added the enhancement New feature or request label Feb 2, 2020
@jkvora jkvora mentioned this issue Sep 6, 2020
Closed
@jkvora jkvora linked a pull request Jul 25, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add logger jkvora/wasm-pack-plugin
add webpack logger jkvora/wasm-pack-plugin
2 participants
@xtuc @larsmoa