Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lines overlapping in terminals #3245

Closed
satyamz opened this issue Jun 29, 2018 · 5 comments · Fixed by #3248
Closed

lines overlapping in terminals #3245

satyamz opened this issue Jun 29, 2018 · 5 comments · Fixed by #3248
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@satyamz
Copy link
Contributor

satyamz commented Jun 29, 2018 •
edited
Loading

Lines in the log output of pod shown in the weave scope terminal are overlapping.

Environment Details:
Kubernetes Version: 1.9.6-gke

screenshot from 2018-06-29 15-49-51
@satyamz satyamz changed the title Lines overlapping & pop-out is not showing any log data in Pod terminal Lines overlapping in logs of Pod in weave scope terminal Jun 29, 2018
@rade rade changed the title Lines overlapping in logs of Pod in weave scope terminal lines overlapping in terminals Jun 29, 2018
@rade
Copy link
Member

rade commented Jun 29, 2018

This happens for all terminals - host, container attach, container exec, and pod logs.

@rade rade added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Jun 29, 2018
@satyamz
Copy link
Contributor Author

satyamz commented Jun 29, 2018

Hi @rade I can confirm that this issue is not there in weave scope 1.9.0
screenshot from 2018-06-29 20-23-17

@foot
Copy link
Contributor

foot commented Jul 2, 2018

It looks like this: xtermjs/xterm.js#1170

Which indicates it might be a chrome only issue, does this match your experience or happening under firefox too?

@rade
Copy link
Member

rade commented Jul 2, 2018

I am seeing this in FF.

@foot foot mentioned this issue Jul 2, 2018
Merged
@foot foot closed this as completed in #3248 Jul 3, 2018
@satyamz
Copy link
Contributor Author

satyamz commented Jul 3, 2018

@foot Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes monospace font overlapping in terminal+linux weaveworks/scope
3 participants
@foot @rade @satyamz