From 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d Mon Sep 17 00:00:00 2001 From: Joshua Bell Date: Mon, 22 Oct 2018 13:48:09 -0700 Subject: [PATCH] Web Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: https://github.com/WICG/web-locks/issues/51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell Commit-Queue: Victor Costan Reviewed-by: Victor Costan Cr-Commit-Position: refs/heads/master@{#601716} --- web-locks/web-locks.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web-locks/web-locks.idl b/web-locks/web-locks.idl index 351c1c5d822032..14bc3a22cc395f 100644 --- a/web-locks/web-locks.idl +++ b/web-locks/web-locks.idl @@ -16,7 +16,7 @@ interface LockManager { Promise query(); }; -callback LockGrantedCallback = Promise (Lock lock); +callback LockGrantedCallback = Promise (Lock? lock); enum LockMode { "shared", "exclusive" };