Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative reference for Per-Message Compression Extension (RFC 7692)? #63

Open
ADKaster opened this issue Jan 14, 2025 · 2 comments
Open

Comments

@ADKaster
Copy link

What is the issue with the WebSockets Standard?

I noticed that there is no normative reference for RFC 7692 in https://websockets.spec.whatwg.org/#normative

However, establish a WebSocket connection step 9 mentions the Sec-WebSocket-Extensions header defined in RFC 7692, and references the original WebSocket standard RFC instead of the extension's RFC in the trailing reference link.

  1. Let permessageDeflate be a user-agent defined "permessage-deflate" extension header value. [WSP]
  2. Append (Sec-WebSocket-Extensions, permessageDeflate) to request’s header list.

This leads to two questions:

  1. Should step 9 of establish a WebSocket connection normatively reference RFC 7692?
  2. Is a user agent that does not support permessage-deflate conforming to the WhatWG WebSockets standard?
@annevk
Copy link
Member

annevk commented Jan 15, 2025

I think the answers are 1) yes and 2) no. Though as always if no user agent actually implements this we might have to revisit things so looking at the existing test coverage is probably a good idea.

@ricea
Copy link
Collaborator

ricea commented Jan 15, 2025

Oops, looks like this is completely untested by wpt.

We have some layout tests for Blink, but they use the obsolete test framework meaning porting involves more work than just search-and-replace.

In case anyone reading this has free time, the files to port are found by this query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants