Generating EAC log checksums

[puddly]

Is this logger meant to generate EAC-compatible or just EAC-style logs? I implemented the EAC log signing algorithm in Python a few months ago. The code is ugly, but it's short and can easily be integrated to create logs that are indistinguishable from EAC's.

[JoeLametta]

Is this logger meant to generate EAC-compatible or just EAC-style logs?

It was developed because, at the time, it seemed that having an EAC-style logger would have made more likely to see whipper being adopted by private trackers. In the meantime lots has changed, whipper further evolved. Right now I think whipper's internal logger (YAML-like) is superior: I'm not even sure if I'm going to make it compatible with whipper v0.6.0. 😄

I implemented the EAC log signing algorithm in Python a few months ago.

Cool work!

The code is ugly, but it's short and can easily be integrated to create logs that are indistinguishable from EAC's.

Don't know what's the story behind EAC's log checksum introduction: I suppose it was added to try to thwart user log spoofing attempts (something usually convicted in private trackers land). I think this is a pointless effort (you can't make a log tamper-proof) and I'm not convinced by the underlying motivations.
I'm sorry to reply to your question (with a partial answer and) another question: what do you think would be the benefits of adding an EAC-verifiable log checksum to morituri-eaclogger?

Thanks,
Joe

[puddly]

That's fine, I was just suggesting it. I thought this logger was still being actively developed given the recent commits.

what do you think would be the benefits of adding an EAC-verifiable log checksum to morituri-eaclogger?

The logger clearly attempts to produce a log file that looks exactly like EAC's, down to the whitespace and number of digits in formatted numbers. You already have your own SHA-256 log checksum in the right format, so why not just make it fully compatible? You could then use whipper to make rips with logs for trackers that will never support whipper.

[lemontoucher]

@JoeLametta I second this. I would really love to be able to use whipper on private trackers since EAC in Wine is a hacky mess. If most of the code has already been written, is it possible to merge it? Also, if merged, would EAC checksums be the last thing required for whipper's logs to be verifiable with EAC's own CheckLog.exe utility?

[Goldmaster]

@puddly wonder if you have forked and worked on adding checksum, whether it would be worth then opening a pull request so that @JoeLametta can merge?

[kpcenti]

Is this still being considered?