Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashing Commits Instructions unclear in README #253

Open
annalorimer opened this issue Aug 26, 2016 · 6 comments
Open

Squashing Commits Instructions unclear in README #253

annalorimer opened this issue Aug 26, 2016 · 6 comments

Comments

@annalorimer
Copy link
Member

annalorimer commented Aug 26, 2016

Problem:

  • README doesn't address:
    • When during the pull request process commits should be squashed
    • Doesn't explain what is actually means to squash a commit
  • Possible mistakes:
    • "git push --force" should be "git push origin BranchName --force"
@evykassirer
Copy link
Member

evykassirer commented Aug 26, 2016

hm I think after the first time you push, it'll know what "push --force" means (at least, I only have to say git push)

but great points! we haven't actually specified when they should be squashed, but I like the idea of it happening at the end because then you can see the difference between commits as you go and what things you fixed

@annalorimer
Copy link
Member Author

For me it didn't know where to push to for "git push --force", although it's entirely possible there was something else wrong.

I agree about doing it at the end.

@evykassirer
Copy link
Member

ah, yeah

every time I do git push the first time it's like "did you mean git push ....... and then I copy paste that and forget about what it was :p we could explain this better

@fboxwala
Copy link
Contributor

We had similar problems with the page in the git workshop, and Elana added helpful info to it. Could copy paste from there to README or link there from readme?

@annalorimer
Copy link
Member Author

Just went through the instructions again for a recent pull request. The paragraph is really dense and hard to parse.

Also, the simple git push --force does not work. It needs to be git push origin BranchName --force.

@arshiamufti
Copy link
Contributor

I'll take this on. I also propose we pull all the git related stuff from the README into a second file--it takes ages to find stuff on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants