-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipping for background
mistakes percentages in color functions for background-position
#92
Comments
background
shorthand propertybackground
shorthand breaks CSS4 space-separated color functions
@HumansCanWinElves Thanks for filing this bug. Looks like this is specific to the new space-separated color functions, which CSSJanus does not yet know about. |
@Krinkle the issue isn't just about the new space-separated syntax. It is the same with the old comma-separated syntax of the For example, background: hsl(150, 30%, 30%); becomes background: hsl(150, 70%, 30%); |
background
shorthand breaks CSS4 space-separated color functionsbackground
mitakes percentages in color functions for background-position
background
mitakes percentages in color functions for background-positionbackground
mistakes percentages in color functions for background-position
@Krinkle Hello I want to work on this issue, the code where the issue is occurring has been identified. |
@AbhineetSaha It looks like code changes must be pushed to their Gerrit repository as this is a read-only mirror |
Consider the following definition:
The percent values are about the saturation and lightness of the generated color and are unrelated to directions.
Yet, when passing it through CSSJanus you get:
which is totally wrong.
Another example:
turns into
The root cause is probably this regex which tries to capture background-position values out of the
background
shorthand property.(As a side note, I'm not sure how this is even supposed to work well for actual position values, considering that the default alignment direction is still "left". For example,
turns into
which seems off)
The text was updated successfully, but these errors were encountered: