Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engineHolder.get().invokeFunction("renderServer", comments) too slow #6

Open
heyao opened this issue Aug 29, 2015 · 6 comments
Open

engineHolder.get().invokeFunction("renderServer", comments) too slow #6

heyao opened this issue Aug 29, 2015 · 6 comments

Comments

@heyao
Copy link

heyao commented Aug 29, 2015

every execute this method elapsed about 1 minutes.
@sdeleuze
Copy link

sdeleuze commented Sep 8, 2015

Maybe linked to https://bugs.openjdk.java.net/browse/JDK-8134403 ...

@winterbe
Copy link
Owner

winterbe commented Sep 8, 2015

Didn't noticed such slow perf at the time coding this example. What Java Version do you use?

@heyao
Copy link
Author

heyao commented Sep 9, 2015

1.8.0_40-b25

@winterbe
Copy link
Owner

winterbe commented Sep 9, 2015

Perf bug mentioned by @sdeleuze is fixed for 8u66. You could test with an older Java version like 8u31.

@heyao
Copy link
Author

heyao commented Sep 9, 2015

@winterbe thanks

@kajmagnus kajmagnus mentioned this issue Sep 16, 2015
Closed
@simbo1905
Copy link

I was interested to see what the performance was like. I also wanted to try out the CompiledScript. Here is a commit that tries a hundred runs as-is then a hundred runs as CompiledScript. Plotting output out of mvn test shows on my macbook pro an average runtime of 12.3ms for the original approach and 10.7 for the CompiledScript approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdeleuze @simbo1905 @winterbe @heyao