Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass original locals to the 404 page render #12935

Merged
merged 6 commits into from
Jan 9, 2025
Merged

pass original locals to the 404 page render #12935

merged 6 commits into from
Jan 9, 2025
+127 −1

Conversation

AirBorne04
Copy link
Contributor

@AirBorne04 AirBorne04 commented Jan 8, 2025 •
edited
Loading

Changes

Docs

  • no doc update required because this is probably expected behavior

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c879fa2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 8, 2025
@AirBorne04 AirBorne04 mentioned this pull request Jan 8, 2025
Closed
1 task
@AirBorne04 AirBorne04 linked an issue Jan 8, 2025 that may be closed by this pull request
Cloudflare context is not avaiable in middleware on 404 route #12821
Closed
1 task
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12935 will not alter performance

Comparing AirBorne04:context-on-404 (c879fa2) with main (2c99b52)

Summary

✅ 6 untouched benchmarks

ematipico
ematipico reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of having a test to prevent future regressions?

@AirBorne04
Copy link
Contributor Author

Any chance of having a test to prevent future regressions?

Sure thing, I managed to to add the check for dynamic 404 pages and a check for 404 redirected page renders.

@ematipico ematipico merged commit 3d47e6b into withastro:main Jan 9, 2025
6 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare context is not avaiable in middleware on 404 route
2 participants
@AirBorne04 @ematipico