Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #13035
getLocaleRelativeUrl
will now return a '/' instead of an empty string in the case ofbase: '/'
andtrailingSlash: 'never'
.Changing this behavior of
getLocalRelativeUrl
caused a similar error ingetLocaleAbsoluteUrl
fortrailingSlash: 'never'
because it internaly usesgetLocaleRelativeUrl
. This is resolved similarly.Testing
Added tests for both cases - the logic for testing
base: '/'
had only been testing whentrailingSlash:'always'
.Docs