Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response to TRACE request is 404 instead of 405 #13104

Open
1 task
corneliusroemer opened this issue Jan 30, 2025 · 0 comments · May be fixed by #13101
Open
1 task

Response to TRACE request is 404 instead of 405 #13104

corneliusroemer opened this issue Jan 30, 2025 · 0 comments · May be fixed by #13101
Assignees
@corneliusroemer
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@corneliusroemer
Copy link

Astro Info

N/A

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When issuing a TRACE request against the minimal example using latest astro results in 404 NOT FOUND instead of the correct mirroring of request or 405 METHOD NOT ALLOWED

$ pnpm --filter @example/minimal i; pnpm --filter @example/minimal build; pnpm --filter @example/minimal preview &

$ curl -X TRACE localhost:4321 -i

HTTP/1.1 404 Not Found
Vary: Origin
Date: Thu, 30 Jan 2025 23:53:18 GMT
Connection: keep-alive
Keep-Alive: timeout=5
Content-Length: 4294

<!doctype html>
<html lang="en">
        <head>
                <meta charset="UTF-8">
                <title>404: Not Found</title>
                <style>
                        :root {
                                --gray-10: hsl(258, 7%, 10%);
                                --gray-20: hsl(258, 7%, 20%);
                                --gray-30: hsl(258
...

What's the expected result?

HTTP/2 405
date: Thu, 30 Jan 2025 23:53:57 GMT
content-length: 0

Link to Minimal Reproducible Example

N/A

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 30, 2025
@ematipico ematipico linked a pull request Jan 31, 2025 that will close this issue
Open
@ematipico ematipico added the - P3: minor bug An edge case that only affects very specific usage (priority) label Jan 31, 2025
@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneliusroemer corneliusroemer

Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: respond with 200 to HEAD requests for non-prerendered pages as well corneliusroemer/astro
2 participants
@ematipico @corneliusroemer