Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jade] Error "The signer does not have a key in this wallet" #1127

Open
pythcoiner opened this issue Jun 21, 2024 · 3 comments · May be fixed by #1142
Open

[Jade] Error "The signer does not have a key in this wallet" #1127

pythcoiner opened this issue Jun 21, 2024 · 3 comments · May be fixed by #1142
Assignees
@pythcoiner

Comments

@pythcoiner
Copy link
Collaborator

pythcoiner commented Jun 21, 2024 •
edited
Loading

image
Context:

  • Initial setup of the jade (importing a seed)
  • Liana restore process while rescanning on a remote bitcoind
  • Jade plugged after liana startup

edit for context: user error, i imported the wrong descriptor, but error wording is misleading, we should have something like The signer key does not match this wallet or something like this.
@nondiremanuel
Copy link
Collaborator

The error message seems pretty clear to me, tbh. What is the confusion in your opinion?

@pythcoiner
Copy link
Collaborator Author

the signer have a key, but the key not matching our descriptor, it's a nit, will take a look later

@pythcoiner pythcoiner linked a pull request Jun 27, 2024 that will close this issue
Open
@pythcoiner
Copy link
Collaborator Author

I've PR'd but feel free to close it if you think original wording is better

@nondiremanuel nondiremanuel moved this to In Review in Liana General Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pythcoiner pythcoiner

Labels
None yet
Projects
Liana General
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change warning when signer have a key not matching the wallet pythcoiner/liana
2 participants
@nondiremanuel @pythcoiner